Size Change: -25 B (0%)

Total Size: 1.11 MB

_{compressed-size-action}

Hey, @gziolo These changes are valid in the current state but I'm afraid that we will support the color flag in mobile blocks one by one. What should we do if we would like to support the color flag for a paragraph at first and then add it to other blocks? Should we create our own list with blocks that support that flag? We could also turn off the color flag for all blocks as it is implemented in this PR and add it manually. I mean add color edit to the InspectorControls as in the Button block case. https://github.com/WordPress/gutenberg/blob/master/packages/block-library/src/button/edit.native.js#L522

Our plan was to add support of showing colors in blocks and then just remove the check Platform.OS === 'web' to automatically add the ColorEdit in the InspectorControls.

Nothing changes from our perspective since we support colors only for Button which doesn't use the color flag at all. But later, we would like to use that flag and we would need to support it for all blocks (with the __experimentalColor) or we couldn't use it at all.

These changes are valid in the current state but I'm afraid that we will support the color flag in mobile blocks one by one. What should we do if we would like to support the color flag for a paragraph at first and then add it to other blocks? Should we create our own list with blocks that support that flag?

Thanks for checking, can you keep a list of blocks as an additional check for mobile? Something like:

const hasColorSupport = ( blockType ) =>
 	( Platform.OS === 'web' || [ 'core/block-1', 'core/block-2' ].includes( blockType ) )
        && hasBlockSupport( blockType, COLOR_SUPPORT_KEY );

Thanks for checking, can you keep a list of blocks as an additional check for mobile? Something like:

It is what i meant

Should we create our own list with blocks that support that flag?

I think we can, however, IMO it should be a temporary solution and ultimately we would like to support the color flag on mobile as well :)

cc: @lukewalczak @pinarol

@dratwas thanks for confirming, could you also give a quick test to this PR on mobile side and approve accordingly? Let's also check columns block inserter support as it was also leaning on a support flag.

Thank you @dratwas for cooperation :)